envoyproxy/envoy

[xds] ADS reject duplicate resources in grpc_mux

Open

#14,847 opened on Jan 28, 2021

View on GitHub
 (8 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/xdsbughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: in grpc_mux_impl, let's reject a resonse when we see duplicate resources.

Description: see https://github.com/envoyproxy/envoy/blob/main/source/common/config/grpc_mux_impl.cc#L224 We want to not "dedup" but reject the response here when the emplace fails

new_grpc_mux_impl seems doesnt have same issue as it push dup resources to each xds impl, where the dup resources gets rejected.

Repro steps:

send a discoveryResponse with multiple resources with the same name. Envoy accepts it silently.

Contributor guide

Research direction
Inspect the grpc mux impl.cc file and modify the logic to reject duplicate resources when emplace fails.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50