envoyproxy/envoy

Add the filtering parameters of the cluster in the cluster admin interface

Open

#14,702 opened on Jan 14, 2021

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/adminhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Add the filtering parameters of the cluster in the cluster admin interface

Description: Current we curl clusters interface(localhost:15000/clusters) will return all clusters' stats , the response will be too large when the cluster is large. I want to add a cluster_name_prefix param to get only the statistics of the cluster I care about.I don’t know if this requirement is a public requirement, if you don’t mind if I add this feature, I will propose a pr to realize it

The final result is as follows

curl localhost:15000/clusters?cluster_prefix=test_service
test_service_1::127.0.0.1:15000::cx_active::0
test_service_1::127.0.0.1:15000::cx_connect_fail::0
test_service_2::127.0.0.1:15000::cx_active::0
test_service_2::127.0.0.1:15000::cx_connect_fail::0

Contributor guide

Research direction
Examine the admin handler for the /clusters endpoint, parse the new query parameter 'cluster prefix', and filter the cluster statistics accordingly.
Tech stack
None
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++HTTPEnvoy basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70