envoyproxy/envoy

HTTP health check filter depends on stats

Open

#14,610 opened on Jan 8, 2021

View on GitHub
 (10 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/health_checkingarea/statsbughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: HTTP health check filter depends on stats

Description: The HTTP health check filter relies on the presence of the following stats: membership_total, membership_healthy, and membership_degraded. Running a configuration that filters out these stats will cause the filter to not work properly. Like #9856, this falls into the category of using stats for control flow.

Contributor guide

Research direction
Examine the health check filter code to understand how stats are used and ensure the filter works even when those stats are filtered out.
Tech stack
cpp
Domain
infrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50