envoyproxy/envoy

Specify -Wdeprecated-declarations for proto targets

Open

#14,281 opened on Dec 4, 2020

View on GitHub
 (8 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/buildhelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

The deprecated proto fields are generating a whole lot of warnings:

bazel-out/k8-fastbuild/bin/external/envoy_api/envoy/config/core/v3/config_source.pb.h:102:3: note: declared here
  102 |   ApiConfigSource_ApiType_hidden_envoy_deprecated_UNSUPPORTED_REST_LEGACY PROTOBUF_DEPRECATED_ENUM = 0,

We should set the -Wdeprecated-declarations for proto targets to suppress this warning.

Contributor guide

Research direction
Locate the BUILD file for proto targets in the repository and add ' Wdeprecated declarations' to the copts attribute.
Tech stack
cpp
Domain
backend
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Bazel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90