envoyproxy/envoy

compression: GET and HEAD headers do not match

Open

#14,225 opened on Dec 1, 2020

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/compressionhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Content-Encoding header is not added to HEAD responses.

Description: Following header is not present in HEAD responses: content-encoding: gzip

RFC7231 specifies the following:

The server SHOULD send the same header fields in response to a HEAD request as it would have sent if the request had been a GET, except that the payload header fields (Section 3.3) MAY be omitted.

(NB! Content-Encoding is not in the list of payload-specific headers.)

Therefore this may cause issues with clients that follow RFC and expect HEAD and GET headers to match.

cc: @rojkov @antoniovicente

Contributor guide

Research direction
Find where Content Encoding header is added for GET responses and ensure the same logic applies to HEAD responses. Check the compression filter code and verify compliance with RFC 7231.
Tech stack
cpp
Domain
backendnetworking
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70