envoyproxy/envoy

stats: allow pre-defined tags

Open

#14,071 opened on Nov 17, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/statshelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

The internal API to create tags has two versions:

  1. Create from qualified stat name.
  2. Create from stat name plus a set of tags.

We'd like to have a third version:

  1. Create from stat name plus a set of tag names. Tag names match against the content of the stat to obtain values. For example, stat "a.b.c" with tag names "d.e" produces "a{d=b,e=c}". Here the separator is a dot, but could be any special character.

The benefit is two-fold:

  1. Save on space, instead of "a.d.b.e.c" we can share "d" and "e" symbols between stat names with different tag values.
  2. Simplify user experience by not required regexes to achieve the same effect.

Contributor guide

Research direction
Examine the current tag creation API in source/common/stats/ and implement a new function that accepts a stat name and a list of tag names, using dot (or other separator) to extract values from the stat name.
Tech stack
cpp
Domain
backendobservability
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65