envoyproxy/envoy

Increase test coverage for io_socket_handle_impl event handling

Open

#13,786 opened on Oct 27, 2020

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
help wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Description: see discussion in https://github.com/envoyproxy/envoy/pull/13478#discussion_r512835272

Add tests to validate the logic when file_event_ is a nullptr.

Contributor guide

Research direction
Understand the event handling logic when `file event ` is nullptr and write unit tests to cover that scenario.
Tech stack
cpp
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75