envoyproxy/envoy

wasm: envoy specific ABI to add tags to active span

Open

#13,731 opened on Oct 23, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/tracingarea/wasmhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: envoy specific ABI to add tags to active span

Description: Currently, we don't have a way to add tags to the active span for a request being processed by wasm filter. We would like to add an envoy specific ABI which would allow us to do the same.

extern "C" WasmResult envoy_set_active_span_tag(const char* key_ptr, size_t key_size,
                                                const char* value_ptr, size_t value_size);

Contributor guide

Research direction
Study the existing WebAssembly ABI in Envoy and understand how to add a new function for setting active span tags. Look at similar ABI functions (e.g., for HTTP headers) for patterns.
Tech stack
wasmcpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++WasmEnvoy proxy concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35