envoyproxy/envoy

Ensure all xDS subscription code handles xDS removals

Open

#13,700 opened on Oct 22, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/xdshelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

With the introduction of Delta xDS support for resource removal was added. While all xDS subscribers are forced to implement the onConfigUpdate function that specifies the removed resources, most of them either reject or ignore this value. We should audit all the resource types and ensure that resources are properly honored.

This will be required before we can be confident that xDS TTL is supported for all resource types.

Contributor guide

Research direction
Audit each xDS subscriber that implements onConfigUpdate and verify that removed resources are properly handled. Start by listing all subscribers and checking if they process the removed resources parameter.
Tech stack
None
Domain
backendinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitC++Envoy development setupUnderstanding of xDS protocol
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20