envoyproxy/envoy

Migrate EDS endpoints_stale_after to xDS TTL

Open

#13,699 opened on Oct 22, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/xdshelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

With the introduction of xDS TTL we can now get rid of the EDS specific option endpoints_stale_after and instead rely on generic TTL support.

To support this we need to ensure that the EDS subscription code is correctly handling an EDS resource removal, which today is ignored. Once this is done we can go ahead and deprecate the endpoints_stale_after field.

Contributor guide

Research direction
Investigate the EDS subscription code to ensure it handles resource removal correctly, then deprecate the endpoints stale after field and use xDS TTL instead.
Tech stack
cpp
Domain
backendinfrastructureapi
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
cppgit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50