envoyproxy/envoy

http: propagate correct reset codes

Open

#13,349 opened on Oct 1, 2020

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/httphelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Hi, we have the following situation: Envoy has received an HTTP request from the client and forwarded that request to the upstream server. While waiting for the HTTP respone from the server, Envoy receives from the client a RST_STREAM packet with error code "CANCEL". This triggers Envoy to send a RST_STREAM packet with a different error code "NO_ERROR" upstream to the server. My question: Why does Envoy not send the same error code to the upstream server that it had received from the client? And would it be possible to configure Envoy to send the same error code as received from the client?

Contributor guide

Research direction
Inspect Envoy's HTTP/2 codec and connection manager to understand how RST STREAM error codes are propagated from downstream to upstream. Look for the logic that translates the client's reset code and see if it can be passed through.
Tech stack
cpp
Domain
backendinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
HTTP/2Envoy basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60