envoyproxy/envoy

thread_local: thread safety follow ups

Open

#13,313 opened on Sep 29, 2020

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/thread_localhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

A couple of follow ups to https://github.com/envoyproxy/envoy/pull/12833:

  1. Try to make the API a bit cleaner with templating: https://github.com/envoyproxy/envoy/pull/12833#discussion_r496594468
  2. Build clang-tidy plugin to check for any TLS functions capturing "this", and fix all current examples. (There are several that capture "this" in the initial set() call, and some that have been "fixed" to use shared_from_this and weak_ptr.)

Contributor guide

Research direction
Review the linked PR #12833 discussion for templating suggestions and examine current TLS functions that capture 'this'.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++clang tidy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30