envoyproxy/envoy

Split FM tests out of conn_manager_impl_test

Open

#13,278 opened on Sep 25, 2020

View on GitHub
 (0 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
help wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

While the FilterManager code has been split out of the HCM, its still just being tested via the HCM tests. To reduce the size of the HCM tests and set the FM up for use cases outside the HCM, we should move tests that make sense into a FM specific set of tests.

Contributor guide

Research direction
Examine the current conn manager impl test.cc to identify tests related to FilterManager. Understand the FilterManager interface and its current usage within HCM tests. Plan a new test file filter manager impl test.cc and move relevant tests, ensuring they compile and pass.
Tech stack
c
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++GitTesting frameworks (e.g., Google Test)
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55