envoyproxy/envoy

access log: add a new response flag to indicate request handled locally by Envoy

Open

#13,100 opened on Sep 15, 2020

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/access_logenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: access log: add a new response flag to indicate request handled locally by Envoy

Description: This is started from the discussion in https://github.com/envoyproxy/envoy/pull/12912#discussion_r490613876 that we could have a more general way to indicate that the request is handled locally by Envoy (sendLocalReply) instead of by upstream.

The response flag could be RESPONDED_BY_FILTER and deprecates the other response_from_cache_filter. The RESPONSE_CODE_DETAIL can be used to learn more details.

cc @htuch

[optional Relevant Links:]

Any extra documentation required to understand the issue.

Contributor guide

Research direction
Understand the sendLocalReply flow and how response flags are currently set. Then add a new flag 'RESPONDED BY FILTER' and deprecate the old 'response from cache filter'. Use the response code detail for additional info.
Tech stack
cpp
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
EnvoyC++access logging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40