envoyproxy/envoy

TSAN: fail libc++ build if not using the TSAN specific version of libc

Open

#12,600 opened on Aug 11, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/buildhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

I killed a bunch of time on this since I didn't realize this wasn't baked into --config=clang-tsan. It would be nice if somehow if in a TSAN/libc++ build we had a test that verified the right library is being used and if not has instructions pointing people to either using docker or building the library locally.

Contributor guide

Research direction
Investigate how to detect the version of libc++ being used in the build and add a check that aborts the build with a clear error message if the wrong version is used. Look at the current TSAN build configuration in the Envoy repository to see where the TSAN specific libc++ is provided.
Tech stack
cpp
Domain
build systemdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitDocker
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60