envoyproxy/envoy

There is currently no support for encoding grpc trailers in HTTP responses using the GRPC HTTP1 Reverse Bridge

Open

#12,545 opened on Aug 7, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

In the GRPC HTTP1 Reverse Bridge, there is currently no support to encode custom trailers in the GrpcWeb responses, that will be translated back to GRPC Response trailers. Currently, it seems that just the grpc-status is auto-inferred using the HTTP response code.

Is this something that can be added?

Here is the code for the grpc http1 reverse bridge: https://github.com/envoyproxy/envoy/tree/5248a4fb7d4c2a3d1fa151f944d3a63f6b7a06cf/source/extensions/filters/http/grpc_http1_reverse_bridge

Contributor guide

Research direction
Examine the grpc http1 reverse bridge filter code to understand how HTTP response headers and trailers are currently handled. Implement support for encoding custom gRPC trailers by parsing them from the upstream HTTP response and converting them to gRPC trailers in the response.
Tech stack
cpp
Domain
backendinfrastructure
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++EnvoygRPC
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60