envoyproxy/envoy

tracing: Set span.kind tag for opencensus tracer when creating client/server spans

Open

#12,538 opened on Aug 7, 2020

View on GitHubContributor guide
 (11 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/tracingenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently OpenTracing tracers and the zipkin tracer derives the span.kind (or cs/cr/ss/sr annotations) from the tracing config "operation_name" - however opencensus tracer doesn't have this tag set.

The proxy needs to explicitly set this tag when creating the span. This is similiar to #3435 which was resolved in 42a9cae38dd3bf5264fb83f64e310b0d76ea4257 (but this time just for opencensus)

Contributor guide

Research direction
Study the fix for OpenTracing in commit 42a9cae38dd3bf5264fb83f64e310b0d76ea4257 and apply a similar approach to the OpenCensus tracer. Locate where spans are created in the OpenCensus tracer and add logic to set span.kind based on the operation name (client/server).
Tech stack
cpp
Domain
networkingbackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy conceptsTracing concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60