envoyproxy/envoy

config_load_check_tool segfault with sds file

Open

#12,351 opened on Jul 29, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (27,997 stars) (5,373 forks)batch import
area/sdsarea/test flakesbughelp wanted

Description

Title: config_load_check_tool v1.15.0 segfault with sds file

Description: When validating configs that reference sds resources via files the config_load_check_tool segfaults after loading the static config and starting to load the sds resources. This is specific to 1.15 as this worked fine with prior versions

Repro steps: run config_load_check_tool against a configuration that uses sds files. example config that causes error https://gist.github.com/mtalbot/e54a5182e941dda47aa624664f615ea5

Contributor guide

Tech stack
cpp
Domain
backendinfrastructure
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C++ knowledgeDebugging skillsEnvoy config loading system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
10
Research direction
Investigate the config load check tool source code, particularly the section that loads SDS resources. Compare with version 1.14 to identify changes that may have introduced the segfault. Reproduce with the provided example config and use a debugger to capture a stack trace. Review any recent commits related to SDS config loading.
config_load_check_tool segfault with sds file · envoyproxy/envoy#12351 | Good First Issue