envoyproxy/envoy

Incorrect listener readiness reporting

Open

#12,245 opened on Jul 23, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/docshelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

In the process of debugging #11826 , I found that the usual stats for readiness are mis-leading. It can happen that the initial init manager finishes initializing (LDS/CDS accepted, processed, and active), yet the connections will be refused. This is because there is a delay between when init manager finishes and the workers start accepting traffic. I think this is a problem, since it may lead to pre-mature deployment of a proxy before it is ready to serve traffic.

cc @lambdai

Contributor guide

Research direction
Trace the listener readiness flow from init manager to worker acceptance. Focus on the delay between init manager completion and workers starting to accept connections. Review listener manager and worker startup code.
Tech stack
cpp
Domain
backendinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Envoy basicsDebugging skills
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35