envoyproxy/envoy

Exception caused by RTDS misconfiguration not caught by validation server

Open

#12,161 opened on Jul 17, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/runtimebughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

We saw a case in which a misconfiguration at the RTDS layer was not caught by the validation server. In staging (running the server in its normal mode) Envoy crashed with the following exception as expected:

EnvoyException in c-ares callback: envoy.config.core.v3.ApiConfigSource must have a statically defined non-EDS cluster: 'someclustername' does not exist, was added via api, or is an EDS cluster

Ideally this sort of error could be caught in development via running Envoy in validation mode. I've not looked too much into the validation server yet but the exception is thrown after starting main dispatch loop, which I noticed is not part of the validation process today based on the logs I'm seeing.

Contributor guide

Research direction
Investigate the validation server's lifecycle and determine why the RTDS misconfiguration error is not caught before the main dispatch loop.
Tech stack
cpp
Domain
backendnetworking
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50