envoyproxy/envoy

Repeated on-demand vhds updates unsubscribe from previously resolved vhosts

Open

#12,158 opened on Jul 17, 2020

View on GitHub
 (4 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/xdsbughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Description: If a vhost named "foo.com" has been previously resolved, an attempt to resolve "bar.com" will result in "foo.com" vhost being unsubscribed from, and all updates for it lost.

This is due to how GrpcMuxWatch::update is implemented -- it expects a list of resource names that should be watched. The resources which names are not in the list will be unsubscribed from.

edit: not an issue for NewGrpcMuxImpl::addWatch

Contributor guide

Research direction
Examine the implementation of GrpcMuxWatch::update to understand why previously resolved vhosts get unsubscribed when a new vhost is resolved.
Tech stack
cppgrpc
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++gRPC
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30