envoyproxy/envoy

router check tool: support coverage for routes with runtime set to 100%

Open

#11,502 opened on Jun 8, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/route_check_toolhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

The router check tool tests for runtime by treating the runtime setting as enabled when the random_value field is less than the fractional percentage set in the default fraction for the runtime field. To account for when the numerator was 0 (i.e. runtime disabled by default), the tool treats the route as though the numerator is 1 so that users can test for coverage.

A similar workaround needs to be implemented for runtime fractions of 100% (i.e. when the route has runtime enabled by default).

Contributor guide

Research direction
Examine the router check tool's handling of runtime fraction and implement a workaround for fractions set to 100% similar to the numerator 0 workaround.
Tech stack
cpp
Domain
backendnetworking
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++GitEnvoy basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50