envoyproxy/envoy

router check tool: add test support for CORS configs

Open

#11,501 opened on Jun 8, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/route_check_toolhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

The router check tool currently does not support input/validation of CORS properties, which can result in a longer development/testing cycle for those looking to validate CORS changes.

This issue is a feature request to add support for validation. Ideally the implementation would utilize the existing CORS code: https://github.com/envoyproxy/envoy/blob/master/source/extensions/filters/http/cors/cors_filter.cc

Contributor guide

Research direction
Study the existing CORS filter implementation in source/extensions/filters/http/cors/cors filter.cc and add corresponding validation logic and tests in the router check tool.
Tech stack
cpp
Domain
backendnetworking
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60