envoyproxy/envoy

Converge [New]GrpcMuxImpl

Open

#11,477 opened on Jun 5, 2020

View on GitHub
 (8 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/xdshelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

We have two distinct gRPC mux impls for xDS, which impacts velocity as we need to do the same thing twice when working with the xDS transport and will be a source of inconsistency long term. This is some hangover from earlier work on delta xDS.

CC @wgallagher @fredlas

Contributor guide

Research direction
Compare the two GrpcMuxImpl classes, identify common patterns, and design a unified implementation that can handle both delta and SotW xDS. Trace the code paths in the xDS transport to ensure consistency.
Tech stack
cpp
Domain
backendinfrastructure
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35