envoyproxy/envoy

macOS CI: fails to correctly link bazelisk

Open

#11,210 opened on May 15, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/buildhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Azure pipelines agents are not correctly installing/linking bazelisk via https://github.com/envoyproxy/envoy/blob/master/ci/mac_ci_setup.sh. All calls to bazel are using the installed system binary, not the version requested by .bazelversion. This is not an issue in master currently because what is installed and the .bazelversion is the same (3.1.0). However, if the versions are different problems arise, e.g: https://github.com/envoyproxy/envoy/pull/11208

Contributor guide

Research direction
Examine the ci/mac ci setup.sh script to understand how bazelisk is installed and linked. Check if the PATH or symlink setup correctly points to the version specified in .bazelversion. Reproduce the issue by setting a different .bazelversion and observing the failure.
Tech stack
shell
Domain
devopsbuild system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
BashCI/CD
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60