envoyproxy/envoy

memory safety: audit use of static variables

Open

#11,130 opened on May 10, 2020

View on GitHub
 (5 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
help wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

We should audit the use of static variables in the codebase to prevent static initialization/deinitialization order problems internally, and for dependent projects.

The codebase already defines a construct on first use macro. We should audit other static variables that should be migrated, and enforce the pattern via code linting.

Contributor guide

Research direction
Audit all static variables in the codebase, identify those that should use the construct on first use macro, and enforce via linting.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++static variables
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40