envoyproxy/envoy

signal handling: refactor some names for clarity

Open

#11,052 opened on May 4, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
help wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

While working on https://github.com/lyft/envoy-mobile/issue/831 @mattklein123 suggested disabling signal handling. I originally thought he meant the signal handling envoy has for fatal signals using SignalActions, which didn't make much sense in the context we were working in. While I should have understood he meant signal handling for termination, it didn't help that we have several places to "disable signals", and we do so in bazel config, via compiler directives, and in code. We could clean this up and specify which settings work on fatal signals, which on termination signals, etc.

Contributor guide

Research direction
Investigate the signal handling code in the repository, focusing on the naming of functions and config options related to fatal and termination signals, and propose a rename that distinguishes them clearly.
Tech stack
cpp
Domain
infrastructure
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65