envoyproxy/envoy

Support 404 NotFound with gRPC-JSON transcoder when an unknown url comes in

Open

#11,042 opened on May 4, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/grpchelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Currently, if.an unknown or mistyped HTTP request url comes in envoy, it will return something like below(will not delivery to upstream gRPC services):

HTTP/1.1 503 Service Unavailable
content-length: 85
content-type: text/plain
date: Mon, 04 May 2020 13:47:45 GMT
server: istio-envoy
x-envoy-upstream-service-time: 86

upstream connect error or disconnect/reset before headers. reset reason: remote reset

It is a client error. Often in HTTP services, returning a 404 is rational.

It would be great envoy provides this feature.

Contributor guide

Research direction
Examine the gRPC JSON transcoder in Envoy to understand how unknown URLs are handled. Then modify the HTTP connection manager or transcoder to return HTTP 404 instead of 503 when a route is not found.
Tech stack
cpp
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++gRPCHTTP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55