envoyproxy/envoy

Mock stat objects should reuse logic for combining stat name and tags into a full stat name

Open

#10,946 opened on Apr 25, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/statshelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

The mock stat objects allow setting name, tag_extracted_name and tags independently, while real stats will have a name that is is a function of the given name and the provided tags. This discrepancy makes it hard to verify behavior that relies on this invariant.

Contributor guide

Research direction
Find the existing logic that combines stat name and tags into full stat name in real stats, and apply it to mock stat objects.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65