envoyproxy/envoy

Guarantee and optimize v3 internally until close to v4alpha

Open

#10,875 opened on Apr 21, 2020

View on GitHub
 (11 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
api/v3area/perfarea/xdsenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Given that v4 might be further out than the API clock dictates today (https://github.com/envoyproxy/envoy/issues/10852), it might be beneficial to work with v3 inside of Envoy rather than bump to v4alpha. This would allow us to skip VersionConverter::upgrade for v3 protos in onConfigUpdate(), eliminating a source of non-trivial overhead that exists today.

This issue will track discussion around using v3 vs. v4alpha and future optimization work to skip the upgrade for known latest version protos (should be very easy to bypass based solely on type URL analysis).

Contributor guide

Research direction
Investigate the performance impact of VersionConverter::upgrade in onConfigUpdate for v3 protos and design a method to skip it using type URL analysis to avoid future upgrade overhead.
Tech stack
cpp
Domain
backendnetworking
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40