envoyproxy/envoy

retries: Make retry budgets default

Open

#10,869 opened on Apr 21, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/retryhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Currently, the max_retries circuit breaker is set to a static value of 3 by default. Retry budgets enable a better way to protect against retry storms that scales with the number of active requests.

One may have the same behavior as the static max_retries circuit breaker using retry budgets by setting the percentage to 0% and a minimum retry concurrency of the desired static value, so it might also be worth discussing whether the max_retries circuit breaker could be deprecated.

Contributor guide

Research direction
Investigate the current max retries default and the retry budget configuration. Determine the impact of changing the default to enable retry budgets with 0% budget and a minimum retry concurrency of 3 to mimic the old behavior. Consider deprecation of max retries.
Tech stack
cpp
Domain
backendnetworkinginfrastructure
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30