envoyproxy/envoy

tools/api: `*.proto` file that consists solely of `import public` statements gets removed from the next API version

Open

#10,745 opened on Apr 12, 2020

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
apiapi/v3bughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: *.proto file that consists solely of import public statements gets removed from the next API version

Context:

  • spotted in config/v3/trace.proto while working on #10743
  • it's not a blocker for trace.proto, though, since this file should be removed in v4 anyway

Contributor guide

Research direction
Inspect the `config/v3/trace.proto` file and trace how API versioning handles files with only `import public` statements.
Tech stack
ccpp
Domain
backendnetworking
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gitprotobuf
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75