envoyproxy/envoy

RTDS snapshot should be pinned to each stream

Open

#10,731 opened on Apr 9, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/runtimehelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: we should keep runtime's consistency during a request's lifecycle.

Description: runtime layers should be consistent during processing of a request.

Repro steps:

a bug scenario: filter A reads version 1 of runtime snapshot, filter A stopIteration, waits for a some callback result, say on-demand-rds a new Runtime snapshot (version 2) is pushed by RTDS, filter A resume the filter iteration, and filter B now sees version 2 when it reads from loader.runtime().snapshot()

IMO, We should latch the runtime snapshot to a stream during its creation time.

Contributor guide

Research direction
Investigate how runtime snapshots are created and used in Envoy, and modify the code to pin the snapshot to each stream at stream creation time.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55