envoyproxy/envoy

windows: Add build verification step to ensure path lengths

Open

#10,581 opened on Mar 30, 2020

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/buildhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

The Windows path length limit is 260 characters and can potentially be exceeded as seen in https://github.com/envoyproxy/envoy/pull/10560. The compiler error emitted when the max path length is exceeded does not point to the actual problem by outputting No such file or directory. It is unclear if this is the only behavior.

Ideally, there would be an explicit check for these path lengths during the Windows build and failure output that clearly indicates the problem.

Contributor guide

Research direction
Build a script or modify the build system (e.g., CMake or Bazel) to check file path lengths during Windows builds and emit a clear error message when paths exceed 260 characters. Investigate existing tools or techniques for path length checking and integrate into the build process.
Tech stack
cpp
Domain
backenddevops
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
WindowsC++ build toolsGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60