envoyproxy/envoy

Returning the correct code when per_try_timeout budget is exhausted

Open

#10,574 opened on Mar 30, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/grpcenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Returning the correct code when per_try_timeout budget is exhausted

Description: If a per_try_timeout budget is exhausted, the returned code is 503. This is arguably correct for HTTP1 but for gRPC communication a deadline-exceeded (setting grpc-status to 4) would be more accurate.

Contributor guide

Research direction
Locate the code where per try timeout is handled and the response status is set. For gRPC, ensure that when the per try timeout budget is exhausted, the response sets grpc status header to 4 (deadline exceeded) instead of returning HTTP 503.
Tech stack
cppgrpc
Domain
backendinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++gRPC
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65