envoyproxy/envoy

RemoteAsyncDataProvider should not re-fetch between xDS refreshes

Open

#10,543 opened on Mar 26, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/xdshelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Currently, LDS update causes a fresh fetch of a Wasm binary. This is unnecessary since the resource comes with a content hash for verification. The request is to make it possible that RemoteAsyncDataProvider caches whatever it fetches and hands it off between xDS resources (e.g. a warming listener should pick it up from a draining listener).

/cc @yxue /cc @jplevyak

Contributor guide

Research direction
Investigate the RemoteAsyncDataProvider class and its caching logic to avoid re fetching Wasm binaries on xDS updates.
Tech stack
cpp
Domain
infrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++EnvoyxDS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30