envoyproxy/envoy

Deprecate Http2ProtocolOptions.allow_connect

Open

#10,412 opened on Mar 17, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/httphelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

PR #9964 introduced user defined HTTP/2 SETTINGS parameters and disallowed overriding "named" parameters (e.g., hpack_table_size) with these custom parameters. However, an exception had to be made for allow_connect, a field for which presence can't be checked due to the use of a scalar type.

An API change must be introduced to remove the exception and enable uniformity in override handling.

Contributor guide

Research direction
Investigate the use of allow connect in Http2ProtocolOptions and remove the special handling for this field to allow uniform override of named settings.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65