envoyproxy/envoy

Migrating to gRPC stats filter for gRPC stats

Open

#10,374 opened on Mar 13, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/grpcarea/statshelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Will using gRPC stats filter in conjunction with gRPC bridge filter lead to twice the number of gRPC stats being emitted?

Description: As of v1.12.0, "The use of gRPC bridge filter for gRPC stats has been deprecated in favor of the dedicated gRPC stats filter." If we still use the gRPC bridge filter for bridging but want to use gRPC stats for stats now that telemetry from the bridge filter is considered deprecated, would it be safe to have both filters? I'm primarily concerned about stats duplication.

Contributor guide

Research direction
Investigate the interaction between gRPC bridge filter and gRPC stats filter in Envoy. Check documentation and source code to determine if using both filters leads to duplicate stats emission. Provide findings and recommendations.
Tech stack
None
Domain
networkingbackend
Issue type
Research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
EnvoygRPC
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65