envoyproxy/envoy

api_listener: allow the api listener to configure settings for the synthetic connection

Open

#10,291 opened on Mar 6, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/connectionarea/listenerenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Description: Right now the SyntheticConnection used inside the Api Listener is not configurable. For instance there is no way to change the return value of the ssl() call. This can have implications in the requests that are created by the Api Listener. For instance, for the example above the value returned by that function dictates the value added for the x-forwarded-proto header here. Therefore, it might be valuable to allow the Api Listener to specify things about its Synthetic Connection.

Contributor guide

Research direction
Examine the SyntheticConnection class in source/server/api listener impl.h and its ssl() method. Understand how it is used in HTTP connection manager utility to set x forwarded proto header. Add configuration options to allow customization of SyntheticConnection settings.
Tech stack
cpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60