envoyproxy/envoy

Move HCM user agent stats functionality into an optional filter

Open

#10,195 opened on Feb 27, 2020

View on GitHubContributor guide
 (11 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/httpbeginnerhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (PR metrics pending)

Description

Right now we have user agent detection built directly into the HCM: https://github.com/envoyproxy/envoy/blob/master/source/common/http/user_agent.h

This code is very old and at this point should not be required to be built into the HCM. We should move this code into an optional filter.

Contributor guide

Research direction
Examine the existing user agent.h and user agent.cc in source/common/http to understand the current implementation. Then, create a new filter that provides the same functionality as an optional filter, following the pattern of other filters in the repository. Ensure it can be enabled/disabled via configuration.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++Envoy development basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65