envoyproxy/envoy

Route actions prefix_rewrite and regex_rewrite should be a oneof

Open

#10,182 opened on Feb 26, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
api/v4help wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Route actions prefix_rewrite and regex_rewrite should be a oneof

Description:

In the discussion for pull request #10050, it was suggested that the prefix_rewrite and regex_rewrite route actions be put under a oneof in the next api version, v4. However, it's too early to mark the proto files with that annotation now, so the code change for #10050 didn't add the annotation. This issue is to remember that this should be considered when the time is appropriate.

Contributor guide

Research direction
Locate the proto definition file where prefix rewrite and regex rewrite are defined and wrap them in a oneof block for v4 API.
Tech stack
None
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Protobuf
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80