envoyproxy/envoy

server: Remove --restart-epoch command-line option because #9888 computes it automatically

Open

#10,139 opened on Feb 22, 2020

View on GitHub
 (2 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/statshelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Currently, a deployment using hot-restart specifies a --restart-epoch epoch_number as a command-line argument to the server. Once #9888 is merged, server.hot_restart_generation will be computed automatically, eliminating the need for scripting to bump the epoch manually.

We should probably not remove that command-line option, however, until sometime after #4980 is merged, because there will be a discontinuity in the server.hot_restart_generation stat.

Then there probably should be a merger of the two stats, eventually dropping one.

Contributor guide

Research direction
Inspect the command line option parsing code in the server directory, understand how the restart epoch is currently used, and coordinate the removal with the merges of #9888 and #4980.
Tech stack
cpp
Domain
backendinfrastructure
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++GitBazel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40