envoyproxy/envoy

Investigate is it okay to kill the connection when the path includes `#`

Open

#10,033 opened on Feb 12, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/httparea/securityhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Issue Template

Title: Investigate is it okay to kill the connection when the path includes #

Description: Quote from the comment in https://github.com/envoyproxy/envoy/pull/10010#discussion_r378329481:

Note: # should be never sent on the wire (at least in theory), so we might want to kill such connections... but this would require investigation to make sure that this wouldn't kill some popular but broken clients.

Contributor guide

Research direction
Review the discussion in PR #10010, especially the comment about '#'. Check if any clients send paths with '#' and assess the impact of killing such connections. Look at existing connection handling code in Envoy to determine where to add the check.
Tech stack
cpp
Domain
backendsecurity
Issue type
Research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++HTTPproxy internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30