enthought/pyface

Unify QApplication.instance() checks

Open

#242 opened on Dec 13, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (54 forks)auto 404
Good First Issuetype: enhancement

Repository metrics

Stars
 (115 stars)
PR merge metrics
 (PR metrics pending)

Description

There are a number of places where we do something like the following:

app = QApplication.instance()
if app is None:
    app = QApplication(*args, **kwargs)

We should refactor so that all such calls go through get_app_qt4 (https://github.com/enthought/pyface/blob/master/pyface/util/guisupport.py#L111) or something similar.

Contributor guide

Research direction
Search the codebase for all occurrences of 'QApplication.instance()' and replace them with calls to the existing 'get app qt4' function in pyface/util/guisupport.py. Ensure the new function handles all arguments correctly.
Tech stack
python
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80