enthought/pyface

Buttons are not set up correctly in ui/qt4/progress_dialog.py

Open

#135 opened on Jul 6, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (54 forks)auto 404
Good First Issue

Repository metrics

Stars
 (115 stars)
PR merge metrics
 (PR metrics pending)

Description

Issue: when clicked, "Cancel" button closes dialog window but does not return self._user_cancelled = True during update or calls reject function.

Possible solution: replace lines 147, 148:

if self.can_cancel:
    buttons.connect(buttons, QtCore.SIGNAL('rejected()'), dialog, QtCore.SLOT('reject()'))

with

if self.can_cancel:
    buttons.clicked.connect(self.reject)

Contributor guide

Research direction
Verify the current behavior by running the progress dialog and clicking Cancel. Then replace lines 147-148 in ui/qt4/progress dialog.py with `if self.can cancel: buttons.clicked.connect(self.reject)` and test that clicking Cancel sets `self. user cancelled = True`.
Tech stack
python
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75