Existing repositories cause clone to fail

Open
#2 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
git, python
Domain
cli, tooling

Research direction

Start in ets/ets.py at line 136, where subprocess.check_call runs git clone with the package URL and destination name. Reproduce the failure with an existing non-empty traits directory, then determine the intended handling for the clone error and verify that the utility behaves as documented when the destination already exists.

Written by the indexing model from the issue text.

Description

Cloning package traits
URL: https://github.com/enthought/traits.git
fatal: destination path 'traits' already exists and is not an empty directory.
Traceback (most recent call last):
File "ets/ets.py", line 149, in
main()
File "ets/ets.py", line 136, in main
subprocess.check_call(['git', 'clone', pkg_url, ets_pkg_name])
File "/home/jwiggins/epd-6.3/lib/python2.6/subprocess.py", line 488, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'clone', 'https://github.com/enthought/traits.git', 'traits']' returned non-zero exit status 128

Perhaps it should just print the error and continue on its merry way?

Dominant language
Python
Stars
33
Forks
10
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from enthought/ets

All issues in enthought/ets

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.