StateSetter.set "ignore" argument does not work

Open
#302 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Locate StateSetter.set and the nested _do_instance calls, then reproduce the list-removal case where a missing item raises ValueError. Trace how the ignore, first, and last arguments are passed into nested set calls; done means missing list items follow the intended ignore behavior and all three arguments are preserved in nested calls.

Written by the indexing model from the issue text.

Description

image

state_keys is a list. Trying to remove an item from a list that is not contained, raises a ValueError, not a KeyError.

Also StateSetter.set arguments "ignore,first,last" are not properly propagated to nested calls to set, e.g. in _do_instance

Dominant language
Python
Stars
38
Forks
21
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from enthought/apptools

All issues in enthought/apptools

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.