emscripten-core/emscripten

Feature request: enable find_package for ICU port

Open

#18,799 opened on Feb 20, 2023

View on GitHub
 (5 comments) (2 reactions) (1 assignee)C++ (27,361 stars) (3,519 forks)batch import
good first bughelp wanted

Description

It seems that some of the ports (SDL, OpenAL, etc) already have find_package enabled (Please correct me if I'm wrong)

It'd be nice to also have it implemented for ICU

find_package(ICU REQUIRED COMPONENTS uc i18n data)

Contributor guide

Tech stack
ccppwasm
Domain
build systemtooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
CMakeEmscripten ports
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine existing ports like SDL and OpenAL to see how find package is enabled. Locate the ICU port's CMakeLists.txt or similar files in the emscripten ports directory. Add the necessary find package calls and potentially a mapping to the system installed ICU. Refer to the issue comments for any additional guidance.