emscripten-core/emscripten

Fail blocking socket operations loudly

Open

#16,047 opened on Jan 17, 2022

View on GitHub
 (5 comments) (1 reaction) (0 assignees)C++ (3,519 forks)batch import
good first bughelp wanted

Repository metrics

Stars
 (27,361 stars)
PR merge metrics
 (Avg merge 19d 10h) (147 merged PRs in 30d)

Description

Would it make sense to fail blocking socket operations fail with an error code or a JavaScript exception?

@tiran encountered a TypeError: Cannot read property 'stream' of undefined error when calling accept on a blocking socket that was more confusing than Error: accept call on blocking socket is not supported would have been.

Contributor guide

Research direction
Inspect the socket accept implementation in Emscripten's C library, trace where the TypeError originates, and add a descriptive error message for blocking socket operations.
Tech stack
ccppjavascript
Domain
backendcompilers
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70