emscripten-core/emscripten

Use console.log to print values of args of emscripten_set_canvas_element_size

Open

#14,551 opened on Jun 29, 2021

View on GitHub
 (3 comments) (1 reaction) (0 assignees)C++ (3,519 forks)batch import
good first bughelp wanted

Repository metrics

Stars
 (27,361 stars)
PR merge metrics
 (Avg merge 19d 10h) (147 merged PRs in 30d)

Description

the type of log message is not considered an error. It is small but makes us confusing as see the console. We might think that an error returned as calling emscripten_set_canvas_element_size. Should be changed to log or info.

https://github.com/emscripten-core/emscripten/blob/9dd9c35fdddc19b9a843cd9406657fc37e16dc45/src/library_html5.js#L2494

Contributor guide

Research direction
Look at line 2494 in src/library html5.js and replace the err() call with console.log() or console.info() to avoid confusion. Also consider if other similar err() calls in the same file should be updated.
Tech stack
javascript
Domain
frontenddeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85